From 0957329c410313f50eeb58ee98f7a61bbda7d104 Mon Sep 17 00:00:00 2001 From: mkelvers Date: Sat, 20 Jun 2026 18:29:25 +0200 Subject: [PATCH] Handle skip segment test cleanup errors --- internal/db/skip_segment_overrides_test.go | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/internal/db/skip_segment_overrides_test.go b/internal/db/skip_segment_overrides_test.go index 92febeb..18882c8 100644 --- a/internal/db/skip_segment_overrides_test.go +++ b/internal/db/skip_segment_overrides_test.go @@ -13,7 +13,11 @@ func TestHasSkipSegmentOverrideTableReturnsFalseWhenMissing(t *testing.T) { if err != nil { t.Fatalf("open sqlite: %v", err) } - defer func() { _ = sqlDB.Close() }() + defer func() { + if err := sqlDB.Close(); err != nil { + t.Errorf("close sqlite: %v", err) + } + }() ok, err := New(sqlDB).HasSkipSegmentOverrideTable(context.Background()) if err != nil { @@ -29,7 +33,11 @@ func TestHasSkipSegmentOverrideTableReturnsTrueWhenPresent(t *testing.T) { if err != nil { t.Fatalf("open test db: %v", err) } - defer func() { _ = sqlDB.Close() }() + defer func() { + if err := sqlDB.Close(); err != nil { + t.Errorf("close sqlite: %v", err) + } + }() queries := New(sqlDB) @@ -47,7 +55,11 @@ func TestSkipSegmentOverrideUpsertAndList(t *testing.T) { if err != nil { t.Fatalf("open test db: %v", err) } - defer func() { _ = sqlDB.Close() }() + defer func() { + if err := sqlDB.Close(); err != nil { + t.Errorf("close sqlite: %v", err) + } + }() queries := New(sqlDB) @@ -118,7 +130,9 @@ func openSkipSegmentOverrideTestDB(t *testing.T) (*sql.DB, error) { ); `) if err != nil { - _ = sqlDB.Close() + if closeErr := sqlDB.Close(); closeErr != nil { + return nil, closeErr + } return nil, err }