melosh/mal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: guard parseVttTime against NaN inputs and strip cue settings from end time

Browse Source
This commit is contained in:
mkelvers
2026-06-24 16:08:00 +02:00
committed by Milas Holsting
parent 2c6e03eee6
commit 2565cdfcc7
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
static/player/subtitles/vtt.ts
View File

@@ -10,7 +10,13 @@ export const parseVttTime = (raw: string): number => {
if (!secPart || !minPart) {
return 0;
}
return Number(hourPart) * 3600 + Number(minPart) * 60 + Number(secPart.replace(",", "."));
const hour = Number(hourPart);
const minute = Number(minPart);
const second = Number(secPart.replace(",", "."));
if (!Number.isFinite(hour) || !Number.isFinite(minute) || !Number.isFinite(second)) {
return 0;
}
return hour * 3600 + minute * 60 + second;
};
// parses a single VTT cue: timestamp line + text lines
@@ -34,7 +40,8 @@ const parseVttCue = (line: string, lines: string[], i: number) => {
if (!text) {
return null;
}
return { start: parseVttTime(startRaw), end: parseVttTime(endRaw), text };
const endTime = endRaw.trim().split(/\s+/)[0] ?? "";
return { start: parseVttTime(startRaw), end: parseVttTime(endTime), text };
};
/**