melosh/mal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: handle mac.Write errors in proxy token signing

Browse Source
This commit is contained in:
mkelvers
2026-05-26 15:56:55 +02:00
parent 3331c96c06
commit 28251876e1
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/playback/service/service.go
View File

@@ -59,7 +59,9 @@ func (s *playbackService) SignProxyToken(targetURL, referer, scope string) (stri
return "", err return "", err
} }
mac := hmac.New(sha256.New, []byte(s.proxyTokenKey)) mac := hmac.New(sha256.New, []byte(s.proxyTokenKey))
mac.Write(body) if _, err := mac.Write(body); err != nil {
return "", fmt.Errorf("sign proxy token: %w", err)
}
signature := mac.Sum(nil) signature := mac.Sum(nil)
encodedBody := base64.RawURLEncoding.EncodeToString(body) encodedBody := base64.RawURLEncoding.EncodeToString(body)
encodedSignature := base64.RawURLEncoding.EncodeToString(signature) encodedSignature := base64.RawURLEncoding.EncodeToString(signature)
@@ -83,7 +85,9 @@ func (s *playbackService) VerifyProxyToken(token string) (proxyTokenPayload, err
return proxyTokenPayload{}, fmt.Errorf("invalid signature encoding: %w", err) return proxyTokenPayload{}, fmt.Errorf("invalid signature encoding: %w", err)
} }
mac := hmac.New(sha256.New, []byte(s.proxyTokenKey)) mac := hmac.New(sha256.New, []byte(s.proxyTokenKey))
mac.Write(body) if _, err := mac.Write(body); err != nil {
return proxyTokenPayload{}, fmt.Errorf("verify proxy token: %w", err)
}
expectedSig := mac.Sum(nil) expectedSig := mac.Sum(nil)
if !hmac.Equal(expectedSig, decodedSig) { if !hmac.Equal(expectedSig, decodedSig) {
return proxyTokenPayload{}, fmt.Errorf("invalid signature") return proxyTokenPayload{}, fmt.Errorf("invalid signature")