melosh/mal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: propagate rand.Read error in token generation

Browse Source
This commit is contained in:
mkelvers
2026-05-26 15:56:49 +02:00
parent 4fc79bc692
commit 3331c96c06
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
internal/auth/service/service.go
View File

@@ -7,6 +7,7 @@ import (
"encoding/base64" "encoding/base64"
"encoding/hex" "encoding/hex"
"errors" "errors"
"fmt"
"mal/internal/domain" "mal/internal/domain"
"strings" "strings"
"time" "time"
@@ -58,7 +59,10 @@ func (s *authService) LoginForAPIToken(ctx context.Context, username, password,
trimmedName = "Firefox extension" trimmedName = "Firefox extension"
} }
rawToken, tokenHash := newOpaqueToken() rawToken, tokenHash, err := newOpaqueToken()
if err != nil {
return "", nil, err
}
if _, err := s.repo.CreateAPIToken(ctx, user.ID, tokenHash, trimmedName); err != nil { if _, err := s.repo.CreateAPIToken(ctx, user.ID, tokenHash, trimmedName); err != nil {
return "", nil, err return "", nil, err
} }
@@ -123,12 +127,14 @@ func (s *authService) RevokeAllAPITokensForUser(ctx context.Context, userID stri
return s.repo.RevokeAllAPITokensForUser(ctx, userID) return s.repo.RevokeAllAPITokensForUser(ctx, userID)
} }
func newOpaqueToken() (token string, tokenHash string) { func newOpaqueToken() (token string, tokenHash string, err error) {
buf := make([]byte, 32) buf := make([]byte, 32)
_, _ = rand.Read(buf) if _, err := rand.Read(buf); err != nil {
return "", "", fmt.Errorf("generate token bytes: %w", err)
}
token = base64.RawURLEncoding.EncodeToString(buf) token = base64.RawURLEncoding.EncodeToString(buf)
sum := sha256.Sum256([]byte(token)) sum := sha256.Sum256([]byte(token))
tokenHash = hex.EncodeToString(sum[:]) tokenHash = hex.EncodeToString(sum[:])
return token, tokenHash return token, tokenHash, nil
} }