melosh/mal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: defer resp.Body.Close in handleResponseRetry

Browse Source
This commit is contained in:
mkelvers
2026-06-16 11:03:42 +02:00
committed by Milas Holsting
parent dc2366cbcc
commit 656ddbd005
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
integrations/jikan/transport/client.go
View File

@@ -166,12 +166,12 @@ func handleRequestRetry(ctx context.Context, err error, attempt int, maxRetries
} }
func handleResponseRetry(ctx context.Context, resp *http.Response, urlStr string, out any, attempt int, maxRetries int) (int, bool, error) { func handleResponseRetry(ctx context.Context, resp *http.Response, urlStr string, out any, attempt int, maxRetries int) (int, bool, error) {
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK { if resp.StatusCode != http.StatusOK {
return handleStatusRetry(ctx, resp, urlStr, out, attempt, maxRetries) return handleStatusRetry(ctx, resp, urlStr, out, attempt, maxRetries)
} }
err := json.NewDecoder(resp.Body).Decode(out) err := json.NewDecoder(resp.Body).Decode(out)
_ = resp.Body.Close()
if err == nil { if err == nil {
return resp.StatusCode, false, nil return resp.StatusCode, false, nil
} }
@@ -196,7 +196,6 @@ func handleStatusRetry(ctx context.Context, resp *http.Response, urlStr string,
} }
if isRetryableStatus(statusCode) && attempt < maxRetries-1 { if isRetryableStatus(statusCode) && attempt < maxRetries-1 {
_ = resp.Body.Close()
if retryErr := waitForRetry(ctx, max(retryAfter, retryDelay(attempt))); retryErr != nil { if retryErr := waitForRetry(ctx, max(retryAfter, retryDelay(attempt))); retryErr != nil {
return statusCode, false, retryErr return statusCode, false, retryErr
} }
@@ -205,7 +204,6 @@ func handleStatusRetry(ctx context.Context, resp *http.Response, urlStr string,
// Best-effort decode (often useful for debugging), but still treat non-200 as error. // Best-effort decode (often useful for debugging), but still treat non-200 as error.
_ = json.NewDecoder(resp.Body).Decode(out) _ = json.NewDecoder(resp.Body).Decode(out)
_ = resp.Body.Close()
return statusCode, false, apiErr return statusCode, false, apiErr
} }