melosh/mal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(playback): consolidate clone functions and choosePlaybackSource

Browse Source
This commit is contained in:
mkelvers
2026-04-20 01:24:07 +02:00
parent 714ea42555
commit 82820f04d3
2 changed files with 17 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
internal/features/playback/service_base.go
View File

@@ -180,7 +180,7 @@ func (s *Service) BuildWatchPageData(ctx context.Context, malID int, titleCandid
StartTimeSeconds: userState.StartTimeSeconds,
CurrentStatus: userState.CurrentStatus,
InitialMode: initialMode,
AvailableModes: cloneStringSlice(baseData.AvailableModes),
AvailableModes: cloneSlice(baseData.AvailableModes),
ModeSources: clientModeSources,
Segments: cloneSegments(baseData.Segments),
}, nil
@@ -336,17 +336,17 @@ func (s *Service) fetchPlaybackSourcesAndSegments(ctx context.Context, showID st
func clonePlaybackBaseData(data playbackBaseData) playbackBaseData {
return playbackBaseData{
Title: data.Title,
AvailableModes: cloneStringSlice(data.AvailableModes),
AvailableModes: cloneSlice(data.AvailableModes),
ModeSources: cloneModeSources(data.ModeSources),
Segments: cloneSegments(data.Segments),
Segments: cloneSlice(data.Segments),
}
}
func cloneStringSlice(items []string) []string {
func cloneSlice[T any](items []T) []T {
if len(items) == 0 {
return nil
}
cloned := make([]string, len(items))
cloned := make([]T, len(items))
copy(cloned, items)
return cloned
}
@@ -367,19 +367,9 @@ func cloneModeSources(modeSources map[string]ModeSource) map[string]ModeSource {
}
func cloneSubtitleItems(items []SubtitleItem) []SubtitleItem {
if len(items) == 0 {
return nil
}
cloned := make([]SubtitleItem, len(items))
copy(cloned, items)
return cloned
return cloneSlice(items)
}
func cloneSegments(segments []SkipSegment) []SkipSegment {
if len(segments) == 0 {
return nil
}
cloned := make([]SkipSegment, len(segments))
copy(cloned, segments)
return cloned
return cloneSlice(segments)
}