refactor: shorten init below funlen threshold

internal/database/fixes/20260608_backfill_anime_duration_seconds.go

@@ -10,50 +10,25 @@ import (
 	"mal/internal/observability"
 )
 
-func init() {
+type animeDurationRow struct {
-	Register(Fix{
-		ID: "20260608_backfill_anime_duration_seconds",
-		Apply: func(ctx context.Context, sqlDB *sql.DB) error {
-			rows, err := sqlDB.QueryContext(ctx, `
-SELECT id, title_original, title_english, title_japanese, image_url, airing
-FROM anime
-WHERE duration_seconds IS NULL;
-`)
-			if err != nil {
-				return fmt.Errorf("query anime rows missing duration_seconds: %w", err)
-			}
-			defer func() { _ = rows.Close() }()
-
-			client := jikan.NewClient(config.Config{}, db.New(sqlDB), observability.NewMetrics())
-
-			type animeRow struct {
 	id            int64
 	titleOriginal string
 }
 
-			var toUpdate []animeRow
+func init() {
-			for rows.Next() {
+	Register(Fix{
-				var row animeRow
+		ID: "20260608_backfill_anime_duration_seconds",
-				var titleEnglish sql.NullString
+		Apply: applyAnimeDurationSecondsBackfill,
-				var titleJapanese sql.NullString
+	})
-				var imageURL string
-				var airing sql.NullBool
-				if err := rows.Scan(
-					&row.id,
-					&row.titleOriginal,
-					&titleEnglish,
-					&titleJapanese,
-					&imageURL,
-					&airing,
-				); err != nil {
-					return fmt.Errorf("scan anime row missing duration_seconds: %w", err)
-				}
-				toUpdate = append(toUpdate, row)
-			}
-			if err := rows.Err(); err != nil {
-				return fmt.Errorf("iterate anime rows missing duration_seconds: %w", err)
 }
 
+func applyAnimeDurationSecondsBackfill(ctx context.Context, sqlDB *sql.DB) error {
+	toUpdate, err := listAnimeMissingDurationSeconds(ctx, sqlDB)
+	if err != nil {
+		return err
+	}
+
+	client := jikan.NewClient(config.Config{}, db.New(sqlDB), observability.NewMetrics())
 	for _, row := range toUpdate {
 		anime, err := client.GetAnimeByID(ctx, int(row.id))
 		if err != nil {
@@ -76,6 +51,41 @@ WHERE duration_seconds IS NULL;
 	}
 
 	return nil
-		},
+}
-	})
+
+func listAnimeMissingDurationSeconds(ctx context.Context, sqlDB *sql.DB) ([]animeDurationRow, error) {
+	rows, err := sqlDB.QueryContext(ctx, `
+SELECT id, title_original, title_english, title_japanese, image_url, airing
+FROM anime
+WHERE duration_seconds IS NULL;
+`)
+	if err != nil {
+		return nil, fmt.Errorf("query anime rows missing duration_seconds: %w", err)
+	}
+	defer func() { _ = rows.Close() }()
+
+	var toUpdate []animeDurationRow
+	for rows.Next() {
+		var row animeDurationRow
+		var titleEnglish sql.NullString
+		var titleJapanese sql.NullString
+		var imageURL string
+		var airing sql.NullBool
+		if err := rows.Scan(
+			&row.id,
+			&row.titleOriginal,
+			&titleEnglish,
+			&titleJapanese,
+			&imageURL,
+			&airing,
+		); err != nil {
+			return nil, fmt.Errorf("scan anime row missing duration_seconds: %w", err)
+		}
+		toUpdate = append(toUpdate, row)
+	}
+	if err := rows.Err(); err != nil {
+		return nil, fmt.Errorf("iterate anime rows missing duration_seconds: %w", err)
+	}
+
+	return toUpdate, nil
 }