melosh/mal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: stop redacting token from request log query params

Browse Source
This commit is contained in:
mkelvers
2026-06-28 12:45:46 +02:00
parent 094d560c30
commit cdcf6a5a2a
2 changed files with 4 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
internal/server/server_test.go
View File

@@ -149,7 +149,7 @@ func TestRequestLoggerLogsFailedStreamProxy(t *testing.T) {
}
}
func TestRequestLoggerRedactsProxyTokenQuery(t *testing.T) {
func TestRequestLoggerLogsProxyTokenQuery(t *testing.T) {
gin.SetMode(gin.TestMode)
var logs bytes.Buffer
@@ -172,11 +172,8 @@ func TestRequestLoggerRedactsProxyTokenQuery(t *testing.T) {
t.Fatalf("status = %d, want %d", rec.Code, http.StatusForbidden)
}
got := logs.String()
if strings.Contains(got, "secret-token") {
t.Fatalf("log line leaked proxy token: %s", got)
}
if !strings.Contains(got, `query="lang=en&token=REDACTED"`) {
t.Fatalf("log line missing redacted query: %s", got)
if !strings.Contains(got, `query="lang=en&token=secret-token"`) {
t.Fatalf("log line missing raw query: %s", got)
}
}