melosh/mal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Handle proxy subtitle errors

Browse Source
This commit is contained in:
mkelvers
2026-06-20 18:29:37 +02:00
committed by Milas Holsting
parent 2f035ebdd9
commit e11a15383c
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
internal/playback/handler/proxy_subtitle.go
View File

@@ -5,6 +5,7 @@ import (
"errors" "errors"
"io" "io"
"mal/internal/observability" "mal/internal/observability"
"mal/pkg/errlog"
netutil "mal/pkg/net" netutil "mal/pkg/net"
"net/http" "net/http"
"strings" "strings"
@@ -34,17 +35,19 @@ func (h *PlaybackHandler) HandleProxySubtitle(c *gin.Context) {
if err != nil { if err != nil {
if !errors.Is(err, context.Canceled) { if !errors.Is(err, context.Canceled) {
observability.ErrorContext(c.Request.Context(), "proxy_subtitle_upstream_failed", "playback", "", map[string]any{"target_url": targetURL}, err) observability.ErrorContext(c.Request.Context(), "proxy_subtitle_upstream_failed", "playback", "", map[string]any{"target_url": targetURL}, err)
_ = c.Error(err).SetType(gin.ErrorTypePrivate) recordPrivateGinError(c, err)
} }
c.Status(http.StatusBadGateway) c.Status(http.StatusBadGateway)
return return
} }
defer func() { _ = resp.Body.Close() }() defer func() {
errlog.Log("failed to close proxy subtitle response body", resp.Body.Close())
}()
body, err := io.ReadAll(io.LimitReader(resp.Body, netutil.MiB2)) body, err := io.ReadAll(io.LimitReader(resp.Body, netutil.MiB2))
if err != nil { if err != nil {
observability.ErrorContext(c.Request.Context(), "proxy_subtitle_read_failed", "playback", "", map[string]any{"target_url": targetURL}, err) observability.ErrorContext(c.Request.Context(), "proxy_subtitle_read_failed", "playback", "", map[string]any{"target_url": targetURL}, err)
_ = c.Error(err).SetType(gin.ErrorTypePrivate) recordPrivateGinError(c, err)
c.Status(http.StatusBadGateway) c.Status(http.StatusBadGateway)
return return
} }