From e40e657d60c3448a090ac9f89367e787506ac813 Mon Sep 17 00:00:00 2001 From: mkelvers Date: Tue, 23 Jun 2026 17:16:36 +0200 Subject: [PATCH] refactor: inline single-use helpers in jikan client --- integrations/jikan/client.go | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/integrations/jikan/client.go b/integrations/jikan/client.go index 2ee7900..990ae8c 100644 --- a/integrations/jikan/client.go +++ b/integrations/jikan/client.go @@ -98,7 +98,7 @@ func jikanCacheLogLevel(source string, err error) observability.LogLevel { } func (c *Client) logJikanCache(cacheKey string, source string, startedAt time.Time, err error) { - if isContextError(err) { + if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) { return } @@ -121,18 +121,6 @@ func (c *Client) logJikanCache(cacheKey string, source string, startedAt time.Ti ) } -func truncateErrorMessage(message string) string { - if len(message) <= 400 { - return message - } - - return message[:400] -} - -func isContextError(err error) bool { - return errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) -} - // notifyRetryWorker signals the retry worker, non-blocking. func (c *Client) notifyRetryWorker() { select { @@ -155,9 +143,14 @@ func (c *Client) EnqueueAnimeFetchRetry(parentCtx context.Context, animeID int, ctx, cancel := context.WithTimeout(parentCtx, 2*time.Second) defer cancel() + message := cause.Error() + if len(message) > 400 { + message = message[:400] + } + err := c.db.EnqueueAnimeFetchRetry(ctx, db.EnqueueAnimeFetchRetryParams{ AnimeID: int64(animeID), - LastError: truncateErrorMessage(cause.Error()), + LastError: message, }) if err != nil { observability.Warn(