melosh/mal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: dedupe watchlist ids

Browse Source
This commit is contained in:
mkelvers
2026-06-01 22:15:21 +02:00
parent bfe23276ba
commit fbd2c5b602
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
internal/watchlist/handler.go
View File

@@ -57,14 +57,12 @@ func (h *WatchlistHandler) HandleUpdateWatchlist(c *gin.Context) {
func (h *WatchlistHandler) HandleDeleteWatchlist(c *gin.Context) { func (h *WatchlistHandler) HandleDeleteWatchlist(c *gin.Context) {
userID := server.CurrentUserID(c) userID := server.CurrentUserID(c)
animeID, err := strconv.ParseInt(c.Param("id"), 10, 64) animeID, ok := parseAnimeIDParam(c)
if !ok {
if err != nil || animeID <= 0 {
server.RespondHTMLOrJSONError(c, http.StatusBadRequest, "invalid anime id")
return return
} }
err = h.svc.RemoveEntry(c.Request.Context(), userID, animeID) err := h.svc.RemoveEntry(c.Request.Context(), userID, animeID)
if err != nil { if err != nil {
server.RespondError( server.RespondError(
c, c,
@@ -84,14 +82,12 @@ func (h *WatchlistHandler) HandleDeleteWatchlist(c *gin.Context) {
func (h *WatchlistHandler) HandleDeleteContinueWatching(c *gin.Context) { func (h *WatchlistHandler) HandleDeleteContinueWatching(c *gin.Context) {
userID := server.CurrentUserID(c) userID := server.CurrentUserID(c)
animeID, err := strconv.ParseInt(c.Param("id"), 10, 64) animeID, ok := parseAnimeIDParam(c)
if !ok {
if err != nil || animeID <= 0 {
server.RespondHTMLOrJSONError(c, http.StatusBadRequest, "invalid anime id")
return return
} }
err = h.svc.DeleteContinueWatching(c.Request.Context(), userID, animeID) err := h.svc.DeleteContinueWatching(c.Request.Context(), userID, animeID)
if err != nil { if err != nil {
server.RespondError( server.RespondError(
c, c,
@@ -108,6 +104,16 @@ func (h *WatchlistHandler) HandleDeleteContinueWatching(c *gin.Context) {
c.Status(http.StatusOK) c.Status(http.StatusOK)
} }
func parseAnimeIDParam(c *gin.Context) (int64, bool) {
animeID, err := strconv.ParseInt(c.Param("id"), 10, 64)
if err != nil || animeID <= 0 {
server.RespondHTMLOrJSONError(c, http.StatusBadRequest, "invalid anime id")
return 0, false
}
return animeID, true
}
func (h *WatchlistHandler) HandleGetWatchlist(c *gin.Context) { func (h *WatchlistHandler) HandleGetWatchlist(c *gin.Context) {
user := server.CurrentUser(c) user := server.CurrentUser(c)
userID := server.CurrentUserID(c) userID := server.CurrentUserID(c)